Fix MigrationGenerator for some columns with underscore #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix for columns like this:
agent_party_id: id foreing:agents.party_id
migration was generated like this:
$table->foreignId('agent_party_id')->constraints();
Which is a problem because this syntax assumes table name is 'agent_parties'.
|
Thanks for this. I would appreciate seeing a test fixture that drove out the solution or document/verifies the change. |
…ure test + fixtures
|
Added strict, fixture-driven test for agent_party_id: id foreign:agents.party_id. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix for columns like this:
agent_party_id: id foreing:agents.party_id
migration was generated like this:
$table->foreignId('agent_party_id')->constraints(); Which is a problem because this syntax assumes table name is 'agent_parties'.